ok lets ship for now

This commit is contained in:
davmar
2026-09-10 20:44:54 +02:00
parent 4dde907f52
commit 3187499385
3 changed files with 186 additions and 9 deletions
+69 -7
View File
@@ -5,6 +5,7 @@ import 'dart:async';
import 'package:flutter/foundation.dart';
import '../models/app_cloud_prefs.dart';
import '../models/home_filter_widget.dart';
import '../models/overview_favourite.dart';
import '../services/pb_sync_service.dart';
@@ -42,6 +43,7 @@ class SyncController extends ChangeNotifier {
_meta.onPersisted = _scheduleMetaPush;
_prefs.onFavouritesPersisted = _scheduleFavouritesPush;
_prefs.onHomeWidgetsPersisted = _scheduleHomeWidgetsPush;
_prefs.onAppPrefsPersisted = _scheduleAppPrefsPush;
_auth.addListener(_onAuthChanged);
_bank.onAfterSuccessfulLoad = _onBankDataLoaded;
if (_auth.isLoggedIn) {
@@ -61,6 +63,7 @@ class SyncController extends ChangeNotifier {
bool _pushMetaPending = false;
bool _pushFavouritesPending = false;
bool _pushHomeWidgetsPending = false;
bool _pushAppPrefsPending = false;
Timer? _pushDebounce;
Timer? _progressHold;
Timer? _uiNotifyThrottle;
@@ -194,6 +197,7 @@ class SyncController extends ChangeNotifier {
_pushMetaPending = false;
_pushFavouritesPending = false;
_pushHomeWidgetsPending = false;
_pushAppPrefsPending = false;
_lastError = null;
_statusDetail = '';
_showProgressRing = false;
@@ -256,6 +260,11 @@ class SyncController extends ChangeNotifier {
_armPushDebounce();
}
void _scheduleAppPrefsPush() {
_pushAppPrefsPending = true;
_armPushDebounce();
}
void _armPushDebounce() {
if (!_auth.isLoggedIn) return;
if (_syncing) {
@@ -332,6 +341,20 @@ class SyncController extends ChangeNotifier {
_prefs.homeFilterWidgets,
remoteHomeWidgets,
);
AppCloudPrefs? remoteAppPrefs;
try {
remoteAppPrefs = await service.pullAppPrefs(onStatus: _setStatus);
} catch (error) {
debugPrint('SyncController: app_prefs pull skipped ($error)');
}
// Prefer local when this device has pending prefs edits; otherwise
// take remote so a new install picks up cloud Home section toggles.
final preferLocalAppPrefs = _pushAppPrefsPending;
final mergedAppPrefs = mergeAppCloudPrefs(
local: _prefs.cloudPrefs,
remote: remoteAppPrefs,
preferLocal: preferLocalAppPrefs,
);
// Apply without notifying — one rebuild after both stores are ready.
await _meta.replaceStore(mergedMeta, notify: false);
await _bank.applySyncedTransactions(remoteTxs, notify: false);
@@ -343,6 +366,7 @@ class SyncController extends ChangeNotifier {
mergedHomeWidgets,
notify: false,
);
await _prefs.replaceCloudPrefs(mergedAppPrefs, notify: false);
_meta.notifyListeners();
_bank.notifyListeners();
_prefs.notifyListeners();
@@ -375,6 +399,15 @@ class SyncController extends ChangeNotifier {
'SyncController: home_filter_widgets push skipped ($error)',
);
}
try {
await service.pushAppPrefs(
mergedAppPrefs,
onStatus: _setStatus,
);
_pushAppPrefsPending = false;
} catch (error) {
debugPrint('SyncController: app_prefs push skipped ($error)');
}
final bankSummary = await service.pushTransactions(
_bank.transactions,
progressStart: 0.82,
@@ -420,20 +453,31 @@ class SyncController extends ChangeNotifier {
final pushMeta = _pushMetaPending;
final pushFavourites = _pushFavouritesPending;
final pushHomeWidgets = _pushHomeWidgetsPending;
final pushAppPrefs = _pushAppPrefsPending;
_pushMetaPending = false;
_pushFavouritesPending = false;
_pushHomeWidgetsPending = false;
if (!pushMeta && !pushFavourites && !pushHomeWidgets) return;
_pushAppPrefsPending = false;
if (!pushMeta && !pushFavourites && !pushHomeWidgets && !pushAppPrefs) {
return;
}
_progressHold?.cancel();
_syncing = true;
_progressSuccess = false;
final label = switch ((pushMeta, pushFavourites, pushHomeWidgets)) {
(false, false, true) => 'Home widgets',
(false, true, false) => 'Favourites',
(false, true, true) => 'Home layout',
(true, false, false) => 'Annotations',
final label = switch ((
pushMeta,
pushFavourites,
pushHomeWidgets,
pushAppPrefs,
)) {
(false, false, false, true) => 'App prefs',
(false, false, true, false) => 'Home widgets',
(false, false, true, true) => 'Home layout',
(false, true, false, false) => 'Favourites',
(false, true, true, _) => 'Home layout',
(true, false, false, false) => 'Annotations',
_ => 'Changes',
};
_statusDetail = 'Pushing $label…';
@@ -446,7 +490,8 @@ class SyncController extends ChangeNotifier {
var done = 0;
final total = (pushMeta ? 1 : 0) +
(pushFavourites ? 1 : 0) +
(pushHomeWidgets ? 1 : 0);
(pushHomeWidgets ? 1 : 0) +
(pushAppPrefs ? 1 : 0);
void bump() {
done++;
_setProgress(done / total);
@@ -494,6 +539,22 @@ class SyncController extends ChangeNotifier {
}
bump();
}
if (pushAppPrefs) {
_setStatus('Pushing app prefs…');
try {
await service.pushAppPrefs(
_prefs.cloudPrefs,
onStatus: _setStatus,
);
parts.add('App prefs updated');
} catch (error) {
debugPrint('SyncController: app_prefs push skipped ($error)');
// Re-queue so a missing collection doesn't drop the edit forever
// until the next manual full sync after migrate.
_pushAppPrefsPending = true;
}
bump();
}
_setProgress(1.0);
_lastSyncedAt = DateTime.now();
@@ -530,6 +591,7 @@ class SyncController extends ChangeNotifier {
_meta.onPersisted = null;
_prefs.onFavouritesPersisted = null;
_prefs.onHomeWidgetsPersisted = null;
_prefs.onAppPrefsPersisted = null;
super.dispose();
}
}